Skip to content

Conversation

@Smartsheet-JB-Brown
Copy link
Contributor

@Smartsheet-JB-Brown Smartsheet-JB-Brown commented Apr 2, 2025

Fixes broken complete prompt when using bedrock provider. This PR is a stand-alone for that fix. I've also incorporated the fix into the AWS Prompt Caching PR, so if that one is merged this one can be rejected.

the previous check of response.output instanceof Uint8Array was always false because of the Bedrock response format.


Important

Fixes completePrompt in AwsBedrockHandler to correctly handle Bedrock response format by checking response.output.message.content[0].text.

  • Behavior:
    • Fixes completePrompt in bedrock.ts to correctly handle Bedrock response format by checking response.output.message.content[0].text.
    • Returns the text content directly if present and non-empty.
  • Tests:
    • Updates tests in bedrock.test.ts to use the new response format for completePrompt.
    • Ensures tests handle cases with valid, invalid, and empty responses.

This description was created by Ellipsis for 3bf3f38. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 9e6377d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Apr 2, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 2, 2025

Thanks! Looks like a test failure though - mind taking a quick look at that?

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 2, 2025
@mrubens mrubens merged commit 0409509 into RooCodeInc:main Apr 2, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 2, 2025
monotykamary pushed a commit to monotykamary/Roo-Code that referenced this pull request Apr 4, 2025
* Add warning for when checkpoints takes too long to load

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants